Skip to content

Conversation

deependujha
Copy link
Collaborator

@deependujha deependujha commented Jul 31, 2025

What does this PR do?

Fixes #<issue_number>

Raises a RuntimeError for any unexpected exception during YAML dumping of hyperparameters.
Prevents silent failures and makes it clear which key/value caused the issue.

Aids in debugging issues #19730 and extends PR #19804.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21020.org.readthedocs.build/en/21020/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 31, 2025
@deependujha
Copy link
Collaborator Author

not planned.

@deependujha deependujha closed this Aug 1, 2025
@deependujha deependujha deleted the fix/yaml-dump-unexpected-error branch August 1, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant