-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Time based validation support #21071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Borda
merged 26 commits into
Lightning-AI:master
from
Sohaib-Ahmed21:feature/13324_validation-interval
Sep 4, 2025
Merged
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
98f608f
Add wall-clock val_check_interval with epoch alignment and timer reset
Sohaib-Ahmed21 e9b66cb
Adjust checkpointing frequency when time-based validation is active
Sohaib-Ahmed21 f29ee07
Add tests for time based validation
Sohaib-Ahmed21 655bb77
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bbeb0de
Address pre-commit hook failures and add comment to explain checkpoin…
Sohaib-Ahmed21 3dc4283
Merge branch 'feature/13324_validation-interval' of https://github.co…
Sohaib-Ahmed21 228f52d
Merge branch 'master' into feature/13324_validation-interval
SkafteNicki 74368ae
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 44e88a4
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 52695b0
Fix mypy check failure and val_check_interval initialization in case …
Sohaib-Ahmed21 4bcd5e8
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 a610ad2
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 64eb3c7
Update docs for time based validation through val_check_interval
Sohaib-Ahmed21 d1411ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 727ce57
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 74176b5
Solve mypy and docs import failures
Sohaib-Ahmed21 591adfc
Merge branch 'feature/13324_validation-interval' of https://github.co…
Sohaib-Ahmed21 06f0c61
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 b67302e
Merge branch 'master' into feature/13324_validation-interval
SkafteNicki 4693672
changelog
SkafteNicki 1b09699
doctest
Borda 69baf1b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d4c83e1
Merge branch 'master' into feature/13324_validation-interval
Borda dbefc8e
Merge branch 'master' into feature/13324_validation-interval
Sohaib-Ahmed21 eaa8a23
Parametrize val_check_interval test to include different types
Sohaib-Ahmed21 01c4fef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.