-
Notifications
You must be signed in to change notification settings - Fork 3.6k
ci: pin also test requirements for minimal setup #21102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates CI workflows to pin test requirements for minimal setup configurations to resolve unexpected breaking changes with DeepSpeed and oldest supported versions. The changes ensure that test dependencies are also pinned to their oldest compatible versions during CI testing.
- Added 'test.txt' to the requirements files list for oldest version pinning in both PyTorch and Fabric workflows
- Reformatted pip install commands for better readability by splitting long lines
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/ci-tests-pytorch.yml | Added 'test.txt' to oldest requirements pinning and reformatted pip install command |
.github/workflows/ci-tests-fabric.yml | Added 'test.txt' and 'examples.txt' to oldest requirements pinning and reformatted pip install command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21102 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 269 269
Lines 23514 23514
=======================================
+ Hits 20500 20503 +3
+ Misses 3014 3011 -3 |
fitting issues with
|
* ci: pin also test requirements for minimal setup * onnx >1.12.0 * numpy >1.20.0 * onnxscript >= 0.1.0 * tensorboard >=2.11 * tensorboardX >=2.6 --------- Co-authored-by: Copilot <[email protected]> (cherry picked from commit a08b64e)
* ci: pin also test requirements for minimal setup * onnx >1.12.0 * numpy >1.20.0 * onnxscript >= 0.1.0 * tensorboard >=2.11 * tensorboardX >=2.6 --------- Co-authored-by: Copilot <[email protected]> (cherry picked from commit a08b64e)
What does this PR do?
this shall resolve unexpected breaking with deepseed and oldest versions
see for example: https://github.com/Lightning-AI/pytorch-lightning/actions/runs/17076057438/job/48417661237
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21102.org.readthedocs.build/en/21102/