Skip to content

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Aug 27, 2025

What does this PR do?

Fixes #20660

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21119.org.readthedocs.build/en/21119/

@SkafteNicki SkafteNicki self-assigned this Aug 27, 2025
@SkafteNicki SkafteNicki requested a review from lantiga as a code owner August 27, 2025 04:35
@SkafteNicki SkafteNicki added the feature Is an improvement or enhancement label Aug 27, 2025
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (9e4d469) to head (257ff99).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21119   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23515    23520    +5     
=======================================
+ Hits        20503    20505    +2     
- Misses       3012     3015    +3     

@Borda Borda merged commit e55650d into Lightning-AI:master Aug 27, 2025
114 of 115 checks passed
Borda pushed a commit that referenced this pull request Aug 28, 2025
* add h200 support to throughput
* add testing
* changelog

---------

Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit e55650d)
lantiga pushed a commit that referenced this pull request Aug 29, 2025
* add h200 support to throughput
* add testing
* changelog

---------

Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit e55650d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: throughput fabric lightning.fabric.Fabric feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update H200 CUDA flops

2 participants