Skip to content

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 1, 2025

What does this PR do?

Simplify GitHub workflow matrix for Fabric tests (similar to #21132).

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21142.org.readthedocs.build/en/21142/

@github-actions github-actions bot added the ci Continuous Integration label Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48%. Comparing base (6fc44c9) to head (d7142b3).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6fc44c9) and HEAD (d7142b3). Click for more details.

HEAD has 132 uploads less than BASE
Flag BASE (6fc44c9) HEAD (d7142b3)
cpu 51 27
python 6 3
lightning 30 15
python3.11 12 6
python3.10 11 6
python3.12.7 17 9
python3.12 5 3
gpu 3 0
pytorch2.2.2 3 0
pytest-full 27 0
pytorch2.3 3 0
pytorch2.1 6 0
pytorch_lightning 12 0
pytorch2.7 3 0
pytorch2.8 3 0
pytorch2.4.1 3 0
pytorch2.5.1 3 0
pytorch2.6 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21142     +/-   ##
=========================================
- Coverage      87%      48%    -39%     
=========================================
  Files         269      266      -3     
  Lines       23560    23504     -56     
=========================================
- Hits        20546    11266   -9280     
- Misses       3014    12238   +9224     

@Borda Borda merged commit e760ad5 into Lightning-AI:master Sep 1, 2025
42 checks passed
@matsumotosan matsumotosan deleted the simplify-fabric-workflow-matrix branch September 1, 2025 16:03
Borda pushed a commit that referenced this pull request Sep 3, 2025
lantiga pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants