Skip to content

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 2, 2025

What does this PR do?

Fixes part of #20984

Exploring if switching over to uv provides CI speedup.

image
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21148.org.readthedocs.build/en/21148/

@github-actions github-actions bot added the ci Continuous Integration label Sep 2, 2025
@matsumotosan matsumotosan changed the title uv for pytorch tests uv for pytorch tests [wip] Sep 2, 2025
@Borda
Copy link
Contributor

Borda commented Sep 2, 2025

'Let''s measure the speed if it makes sense to switch...

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 3, 2025
@Borda Borda changed the title uv for pytorch tests [wip] uv for pytorch tests Sep 3, 2025
@Borda Borda merged commit 29e8ce4 into Lightning-AI:master Sep 3, 2025
60 checks passed
Borda pushed a commit that referenced this pull request Sep 3, 2025
* swap to uv
* no pip cache
* enable caching. use venv.
* activate environment
* fix uninstall
* replace pip with uv
* activate venv
* --find-links=...
* GLOO_SOCKET_IFNAME

---------

Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka B <[email protected]>

(cherry picked from commit 29e8ce4)
@matsumotosan matsumotosan deleted the uv-for-pytorch-tests branch September 3, 2025 12:17
lantiga pushed a commit that referenced this pull request Sep 5, 2025
* swap to uv
* no pip cache
* enable caching. use venv.
* activate environment
* fix uninstall
* replace pip with uv
* activate venv
* --find-links=...
* GLOO_SOCKET_IFNAME

---------

Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka B <[email protected]>

(cherry picked from commit 29e8ce4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants