Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 3, 2025

What does this PR do?

The installation is much faster, so the cost is also lower
also we would be able to to drop building GPU images for CI

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21157.org.readthedocs.build/en/21157/

Copy link
Contributor

github-actions bot commented Sep 3, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_fsdp.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | oldest) success
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_fsdp.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48%. Comparing base (92544c3) to head (bf2e4af).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (92544c3) and HEAD (bf2e4af). Click for more details.

HEAD has 139 uploads less than BASE
Flag BASE (92544c3) HEAD (bf2e4af)
pytest 29 28
lightning 31 15
cpu 53 25
python 6 3
python3.10 12 5
python3.11 12 5
python3.12.7 18 9
pytorch2.1 6 0
pytest-full 27 0
pytorch_lightning 12 0
pytorch2.7 3 0
python3.12 5 3
pytorch2.8 3 0
pytorch2.3 3 0
pytorch2.5.1 3 0
pytorch2.2.2 3 0
pytorch2.4.1 3 0
pytorch2.6 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21157     +/-   ##
=========================================
- Coverage      87%      48%    -39%     
=========================================
  Files         269      266      -3     
  Lines       23656    23600     -56     
=========================================
- Hits        20636    11417   -9219     
- Misses       3020    12183   +9163     

@Borda Borda changed the title run Fabric tests for oldest on T4_x_4 run Fabric tests for oldest with ... [wip] Sep 4, 2025
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 4, 2025
@Borda Borda changed the title run Fabric tests for oldest with ... [wip] run Fabric tests for oldest with uv Sep 4, 2025
@Borda Borda changed the title run Fabric tests for oldest with uv run Fabric tests with uv setup Sep 4, 2025
@Borda Borda changed the title run Fabric tests with uv setup litGPU: run Fabric tests with uv setup Sep 5, 2025
@Borda Borda merged commit 77f9811 into master Sep 5, 2025
50 checks passed
@Borda Borda deleted the ci/fabric-T4_x_4 branch September 5, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants