Skip to content

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Sep 4, 2025

What does this PR do?

Removes parse_as_dict=False from a LightningCLI test. This parameter was deprecated long ago, and the lightning code was already adapted. But one use remained by mistake. Noted only now while running tests with a version of jsonargparse that no longer accepts this parameter.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21159.org.readthedocs.build/en/21159/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 4, 2025
@SkafteNicki SkafteNicki merged commit cdc0db4 into Lightning-AI:master Sep 4, 2025
71 of 74 checks passed
@mauvilsa mauvilsa deleted the cli-parse-as-dict-deprecation branch September 4, 2025 10:43
Borda pushed a commit that referenced this pull request Sep 4, 2025
lantiga pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants