Tuner cleanup on error #21162
Merged
Tuner cleanup on error #21162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Borda
reviewed
Sep 4, 2025
Borda
reviewed
Sep 4, 2025
Borda
approved these changes
Sep 4, 2025
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Sep 4, 2025
* Make sure temp checkpoints are cleaned up on failed tuning * add testing * changelog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit e1e2534)
lantiga
pushed a commit
that referenced
this pull request
Sep 5, 2025
* Make sure temp checkpoints are cleaned up on failed tuning * add testing * changelog --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit e1e2534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13856
Tuner algorithms will currently leave behind temp checkpoints if the tuning for some reason fails. PR makes sure these are cleaned up using
try, except, finallystatements even if tuning crashes.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21162.org.readthedocs.build/en/21162/