Skip to content

fabric: list hydra in optional extra #21165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

fabric: list hydra in optional extra #21165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4a3969
hydra
Borda Sep 4, 2025
407fb53
extra
Borda Sep 4, 2025
5fe1caa
Merge branch 'master' into fabric/extra
SkafteNicki Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions requirements/fabric/extra.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
# in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment

hydra-core >=1.2.0, <1.4.0
2 changes: 1 addition & 1 deletion src/lightning/__setup__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _prepare_extras() -> dict[str, Any]:
}

# project specific extras groups
extras["fabric-all"] = extras["fabric-strategies"] + extras["fabric-examples"]
extras["fabric-all"] = extras["fabric-extra"] + extras["fabric-strategies"] + extras["fabric-examples"]
extras["fabric-dev"] = extras["fabric-all"] + extras["fabric-test"]
extras["pytorch-all"] = extras["pytorch-extra"] + extras["pytorch-strategies"] + extras["pytorch-examples"]
extras["pytorch-dev"] = extras["pytorch-all"] + extras["pytorch-test"]
Expand Down
2 changes: 1 addition & 1 deletion src/lightning_fabric/__setup__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _prepare_extras() -> dict[str, Any]:
}
for req in parse_requirements(extras["strategies"]):
extras[req.key] = [str(req)]
extras["all"] = extras["strategies"] + extras["examples"]
extras["all"] = extras["extra"] + extras["strategies"] + extras["examples"]
extras["dev"] = extras["all"] + extras["test"]
return extras

Expand Down
Loading