Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 8, 2025

What does this PR do?

it shall unblock tests with py3.9

ImportError while loading conftest '/home/runner/work/pytorch-lightning/pytorch-lightning/tests/tests_pytorch/conftest.py'.
conftest.py:25: in <module>
    import torch.distributed
../../.venv/lib/python3.9/site-packages/torch/__init__.py:1332: in <module>
    _C._initExtension(manager_path())
../../.venv/lib/python3.9/site-packages/torch/cuda/__init__.py:51: in <module>
    import pynvml  # type: ignore[import]
../../.venv/lib/python3.9/site-packages/_pynvml_redirector.py:29: in find_spec
    warnings.warn(PYNVML_MSG, FutureWarning, stacklevel=2)
E   FutureWarning: The pynvml package is deprecated. Please install nvidia-ml-py instead. If you did not install pynvml directly, please report this to the maintainers of the package that installed pynvml for you.
/home/runner/work/pytorch-lightning/pytorch-lightning/.venv/lib/python3.9/site-packages/coverage/inorout.py:521: CoverageWarning: Module pytorch_lightning was never imported. (module-not-imported)
  self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
/home/runner/work/pytorch-lightning/pytorch-lightning/.venv/lib/python3.9/site-packages/coverage/control.py:945: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21181.org.readthedocs.build/en/21181/

@github-actions github-actions bot added the ci Continuous Integration label Sep 8, 2025
Copy link
Contributor

github-actions bot commented Sep 8, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | oldest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to pyproject.toml.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to pyproject.toml, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | oldest) success
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to pyproject.toml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to pyproject.toml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (33d748d) to head (cb22192).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21181   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23656    23656           
=======================================
  Hits        20633    20633           
  Misses       3023     3023           

@bhimrazy bhimrazy merged commit d204cb1 into master Sep 8, 2025
91 checks passed
@bhimrazy bhimrazy deleted the uv/UV_TORCH_BACKEND-cpu branch September 8, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants