-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: add support for fsdp2 strategy in trainer #21184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deependujha
wants to merge
18
commits into
Lightning-AI:master
Choose a base branch
from
deependujha:feat/add-support-for-fsdp2-strategy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add support for fsdp2 strategy in trainer #21184
deependujha
wants to merge
18
commits into
Lightning-AI:master
from
deependujha:feat/add-support-for-fsdp2-strategy
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21184 +/- ##
========================================
- Coverage 87% 86% -1%
========================================
Files 269 271 +2
Lines 23665 24051 +386
========================================
+ Hits 20642 20710 +68
- Misses 3023 3341 +318 |
SkafteNicki
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably in a follow up PR:
- documentation similar to https://github.com/Lightning-AI/pytorch-lightning/blob/master/docs/source-fabric/advanced/model_parallel/fsdp.rst
- add fsdp2 to fabric?
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
I would start with FSDP2 in Fabric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21184.org.readthedocs.build/en/21184/