Skip to content

bump: deepspeed to be 0.16 #21194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2025
Merged

bump: deepspeed to be 0.16 #21194

merged 5 commits into from
Oct 17, 2025

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 10, 2025 •
edited by github-actions bot
Loading

What does this PR do?

required for #20461 (comment)

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21194.org.readthedocs.build/en/21194/

cc @justusschock @lantiga

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Sep 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/strategies.txt, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10) success ✅
pytorch.yml / Lit Job (lightning, 3.12) success ✅
pytorch.yml / Lit Job (pytorch, 3.12) success ✅

These checks are required after the changes to requirements/pytorch/strategies.txt, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py, requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success ✅
benchmark.yml / Lit Job (pytorch) success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py, requirements/fabric/strategies.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success ✅
docs-make (pytorch, html) success ✅

These checks are required after the changes to src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py, requirements/pytorch/strategies.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py.

🟢 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, fabric, 3.10) success ✅
fabric.yml / Lit Job (fabric, 3.12) success ✅
fabric.yml / Lit Job (lightning, 3.12) success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/utilities/deepspeed.py, requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (7323bb8) to head (c4c6558).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #21194    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         269      269            
  Lines       23695    23707    +12     
========================================
- Hits        20673    20546   -127     
- Misses       3022     3161   +139

@Borda Borda mentioned this pull request Sep 10, 2025
Merged
7 tasks
@Borda Borda marked this pull request as draft September 16, 2025 17:25
@deependujha
Copy link
Collaborator

deependujha commented Sep 22, 2025

I recommend merging this PR first, followed by tests: fix skipif condition for deepspeed #21195

If we merge in the current order, I expect the tests to fail for the reasons outlined in this comment.

By merging this PR first, the DeepSpeed tests will be skipped (so CI won’t fail). Then, once PR #21195 is merged, the skipif condition will be corrected and the tests should pass as expected.

@Borda
Copy link
Collaborator Author

Borda commented Sep 22, 2025

I recommend merging this PR first, followed by tests: fix skipif condition for deepspeed #21195

I think it's safer to first enable testing before any possible bump...

@Borda Borda closed this Oct 13, 2025
@Borda Borda reopened this Oct 16, 2025
@deependujha deependujha marked this pull request as ready for review October 16, 2025 16:22
@t-vi t-vi merged commit c943c05 into master Oct 17, 2025
119 of 121 checks passed
@t-vi t-vi deleted the bump/deepspeed branch October 17, 2025 08:55
@Borda
Copy link
Collaborator Author

Borda commented Oct 17, 2025

Just for the record their bump landed without any relevant testing so no visibility if tests would pass or not and so potential breaking behaviors...

@deependujha
Copy link
Collaborator

deependujha commented Oct 25, 2025

deepspeed tests were enabled and merged in pr: #21195

justusschock added a commit that referenced this pull request Nov 5, 2025
@Borda @justusschock @deependujha
bump: deepspeed to be 0.16 (#21194)
276cc8c 
* bump: `deepspeed` to be 0.16

* feat: enforce DeepSpeed version requirement for PyTorch >= 2.6 and update checkpoint loading behavior

---------

Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Deependu Jha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@deependujha deependujha deependujha approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Borda @deependujha @tchaton @SkafteNicki @t-vi @justusschock