Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 11, 2025

What does this PR do?

drop non-existent link and related docs section

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21202.org.readthedocs.build/en/21202/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 11, 2025
Copy link
Contributor

github-actions bot commented Sep 11, 2025

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.

🔴 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10, A100_X_2) success
pytorch.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, lightning, 3.12, L4_X_2) in_progress
pytorch.yml / Lit Job (nvidia/cuda:12.6.3-runtime-ubuntu22.04, pytorch, 3.12, L4_X_2) cancelled 🚫

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.

🔴 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) failure

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/loggers/wandb.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (f1ed6a2) to head (f7c1d8b).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (f1ed6a2) and HEAD (f7c1d8b). Click for more details.

HEAD has 117 uploads less than BASE
Flag BASE (f1ed6a2) HEAD (f7c1d8b)
cpu 54 27
python 6 3
lightning_fabric 14 0
pytest 30 0
python3.12 6 3
python3.10 12 6
lightning 31 15
python3.11 12 6
python3.12.7 18 9
gpu 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21202     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23688    23633     -55     
=========================================
- Hits        20666    18636   -2030     
- Misses       3022     4997   +1975     

@Borda Borda changed the title docs: drop broken link fix/docs: drop broken link Sep 12, 2025
@Borda
Copy link
Contributor Author

Borda commented Sep 13, 2025

Seems the link is back live...

@Borda Borda closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants