Skip to content

fix: MLFlowLogger artifact_path #21204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/stable
Choose a base branch
from
Open

fix: MLFlowLogger artifact_path #21204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85c01c6
fix: MLFlowLogger artifact_path (#20669)
yxtay Mar 25, 2025
b81b5a0
test: MLFlowLogger(log_model=True)
yxtay Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lightning/pytorch/loggers/mlflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def _scan_and_log_checkpoints(self, checkpoint_callback: ModelCheckpoint) -> Non
aliases = ["latest", "best"] if p == checkpoint_callback.best_model_path else ["latest"]

# Artifact path on mlflow
artifact_path = Path(self._checkpoint_path_prefix) / Path(p).stem
artifact_path = Path(self._checkpoint_path_prefix, Path(p).stem).as_posix()

# Log the checkpoint
self.experiment.log_artifact(self._run_id, p, artifact_path)
Expand Down
14 changes: 12 additions & 2 deletions tests/tests_pytorch/loggers/test_mlflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def test_mlflow_run_name_setting(tmp_path):
if not _MLFLOW_AVAILABLE:
pytest.skip("test for explicit file creation requires mlflow dependency to be installed.")

import mlflow
from mlflow.utils.mlflow_tags import MLFLOW_RUN_NAME

resolve_tags = _get_resolve_tags()
Expand All @@ -121,6 +122,8 @@ def test_mlflow_run_name_setting(tmp_path):
default_tags = resolve_tags(None)
client.create_run.assert_called_with(experiment_id="exp-id", tags=default_tags)

mlflow.set_tracking_uri(None)


@mock.patch("lightning.pytorch.loggers.mlflow._get_resolve_tags", Mock())
def test_mlflow_run_id_setting(mlflow_mock, tmp_path):
Expand Down Expand Up @@ -177,8 +180,10 @@ def test_mlflow_logger_dirs_creation(tmp_path):
if not _MLFLOW_AVAILABLE:
pytest.skip("test for explicit file creation requires mlflow dependency to be installed.")

import mlflow

assert not os.listdir(tmp_path)
logger = MLFlowLogger("test", save_dir=str(tmp_path))
logger = MLFlowLogger("test", save_dir=str(tmp_path), log_model=True)
assert logger.save_dir == str(tmp_path)
assert set(os.listdir(tmp_path)) == {".trash"}
run_id = logger.run_id
Expand Down Expand Up @@ -208,7 +213,12 @@ def on_train_epoch_end(self, *args, **kwargs):
assert "epoch" in os.listdir(tmp_path / exp_id / run_id / "metrics")
assert set(os.listdir(tmp_path / exp_id / run_id / "params")) == model.hparams.keys()
assert trainer.checkpoint_callback.dirpath == str(tmp_path / exp_id / run_id / "checkpoints")
assert os.listdir(trainer.checkpoint_callback.dirpath) == [f"epoch=0-step={limit_batches}.ckpt"]
ckpt_stem = f"epoch=0-step={limit_batches}"
assert os.listdir(trainer.checkpoint_callback.dirpath) == [f"{ckpt_stem}.ckpt"]
artifacts = mlflow.artifacts.list_artifacts(run_id=logger.run_id)
assert [file_info.path for file_info in artifacts] == [ckpt_stem]

mlflow.set_tracking_uri(None)


@mock.patch("lightning.pytorch.loggers.mlflow._get_resolve_tags", Mock())
Expand Down
Loading