-
Notifications
You must be signed in to change notification settings - Fork 3.6k
debug failing checkout docs/LFS #21208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⛈️ Required checks status: Has failure 🔴
Groups summary🔴 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the documentation build workflow to debug a failing checkout issue in GitHub Actions by enabling recursive submodule cloning and LFS (Large File Support) for all documentation builds instead of only for PyTorch-specific builds.
- Enables recursive submodules and LFS for all package builds (fabric and pytorch) instead of conditionally enabling them only for pytorch
- Simplifies the checkout configuration by removing conditional logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cc: @ethanwharris |
Seems the recursive is fine now, so we can reopen it if needed... 🦩 |
@Borda problem is still present...is this not a fix? |
Yeah, I saw it, but then I observed that it happened also with this PR, so probably I did not find the fix... :( |
What does this PR do?
have this failing github workflow https://github.com/Lightning-AI/pytorch-lightning/actions/runs/17683035964/job/50270918592?pr=21196 but the same checkout is used for the other two passes and also all was pissing earlier today with the very same commit
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21208.org.readthedocs.build/en/21208/