Skip to content

fix: Checkout and Git LFS fetch issue for pytorch docs workflow #21219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 15, 2025
Merged

fix: Checkout and Git LFS fetch issue for pytorch docs workflow #21219

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f79ca3c
Fix Git LFS authentication for docs workflow
bhimrazy Sep 15, 2025
aa3d690
Improve Git LFS fix: set credentials before checkout and add explicit…
bhimrazy Sep 15, 2025
ebb3e74
Fix LFS auth by setting global lfs.url and allow draft PRs
bhimrazy Sep 15, 2025
fc73f32
Fix LFS auth by configuring submodule-specific LFS URL and manual che…
bhimrazy Sep 15, 2025
0cfa843
Disable LFS during checkout and handle LFS manually with proper auth
bhimrazy Sep 15, 2025
aa647ec
Fix LFS by setting correct remote URL and add debugging info
bhimrazy Sep 15, 2025
5127af5
Enhance LFS configuration: set aggressive endpoint access and add env…
bhimrazy Sep 15, 2025
d0feb5c
Bypass LFS completely - download files directly via GitHub API
bhimrazy Sep 15, 2025
ce3ba12
Configure Git LFS authentication and fetch LFS objects for submodule
bhimrazy Sep 15, 2025
6a258a6
Update submodule URL to correct repository: tutorials.git
bhimrazy Sep 15, 2025
5411282
Simplify to standard LFS checkout now that submodule URL is correct
bhimrazy Sep 15, 2025
04d0208
Update condition for docs-make job to only run on non-draft pull requ…
bhimrazy Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions .github/workflows/docs-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ env:

jobs:
docs-make:
if: github.event.pull_request.draft == false
if: github.event_name != 'pull_request' || github.event.pull_request.draft == true
runs-on: ubuntu-22.04
strategy:
fail-fast: false
Expand All @@ -67,9 +67,44 @@ jobs:
- uses: actions/checkout@v5
with:
ref: ${{ inputs.checkout }}
token: ${{ secrets.GITHUB_TOKEN }}
# only Pytorch has/uses notebooks
submodules: ${{ matrix.pkg-name == 'pytorch' }}
lfs: ${{ matrix.pkg-name == 'pytorch' }}
lfs: false # Disable LFS during checkout to avoid auth issues
- name: Setup LFS and fetch notebooks manually
if: ${{ matrix.pkg-name == 'pytorch' }}
run: |
# Configure Git to use token for all GitHub operations
git config --global credential.helper store
echo "https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com" > ~/.git-credentials

# Navigate to submodule and configure LFS with correct URL
cd _notebooks

# Check current remote and LFS config
echo "Current remote:"
git remote -v
echo "Current LFS config:"
git config --list | grep lfs || true

# Set the correct remote URL with token
git remote set-url origin "https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com/Lightning-AI/lightning-tutorials.git"

# Configure LFS more aggressively
git config lfs.url "https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com/Lightning-AI/lightning-tutorials.git/info/lfs"
git config --add lfs.https://github.com/Lightning-AI/tutorials.git/info/lfs.access basic
git config --add lfs.https://github.com/Lightning-AI/lightning-tutorials.git/info/lfs.access basic
git config credential.helper store

# Install and configure LFS
git lfs install

# Try to fetch with environment variable override
export GIT_LFS_ENDPOINT="https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com/Lightning-AI/lightning-tutorials.git/info/lfs"

# Fetch LFS objects
git lfs fetch --all
git lfs checkout
- uses: actions/setup-python@v6
with:
python-version: "3.10"
Expand Down
Loading