-
Notifications
You must be signed in to change notification settings - Fork 3.6k
check the init args only when the given frames are in __init__ method.
#21227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check the init args only when the given frames are in __init__ method.
#21227
Conversation
|
Description updated. This PR should also fix #18405 as well. |
|
Let’s hold off on updating this branch until the bug is fixed |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21227 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 269 266 -3
Lines 23708 23653 -55
=========================================
- Hits 20536 18638 -1898
- Misses 3172 5015 +1843 |
What does this PR do?
Fixes #20697
Fixes #18405
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21227.org.readthedocs.build/en/21227/