Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Sep 16, 2025

What does this PR do?

Fixes #20697
Fixes #18405

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21227.org.readthedocs.build/en/21227/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 16, 2025
@GdoongMathew
Copy link
Contributor Author

Description updated. This PR should also fix #18405 as well.

@deependujha
Copy link
Collaborator

Let’s hold off on updating this branch until the bug is fixed

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (a7cb33a) to head (e99444e).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (a7cb33a) and HEAD (e99444e). Click for more details.

HEAD has 103 uploads less than BASE
Flag BASE (a7cb33a) HEAD (e99444e)
cpu 52 27
python 6 3
lightning_fabric 12 0
pytest 27 0
python3.10 12 6
lightning 29 15
python3.11 12 6
python3.12.7 16 9
python3.12 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21227     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23708    23653     -55     
=========================================
- Hits        20536    18638   -1898     
- Misses       3172     5015   +1843     

@deependujha deependujha merged commit e5a616f into Lightning-AI:master Nov 6, 2025
84 checks passed
@GdoongMathew GdoongMathew deleted the fix/init_parsing branch November 6, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError: 'self' in save_hyperparameters() when custom metaclass used KeyError in save_hyperparameters while using in a subclass

5 participants