Skip to content

Conversation

alpha0422
Copy link

@alpha0422 alpha0422 commented Sep 21, 2025

What does this PR do?

Fixes #21232.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @csarofeen @ptrblck @eqy

…r metrics based on the presence of a progress bar callback.

Signed-off-by: Wil Kong <[email protected]>
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2025
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add one or more unittests for this?
Mostly to check that we do not regress if changes are made to this part of the codebase?

@alpha0422
Copy link
Author

Can we please add one or more unittests for this? Mostly to check that we do not regress if changes are made to this part of the codebase?

Good point, added a few unittests, thanks.

@alpha0422
Copy link
Author

Hi @SkafteNicki, what should I do to move forward?

@SkafteNicki
Copy link
Collaborator

@alpha0422 PR looks fine to me. We are having progrems with our CI at the moment so it may take a bit of time before the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant Host & Device Synchronizations
4 participants