-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove Redundant Host & Device Synchronizations #21233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…r metrics based on the presence of a progress bar callback. Signed-off-by: Wil Kong <[email protected]>
…agement for scalar metrics. Signed-off-by: Wil Kong <[email protected]>
Signed-off-by: Wil Kong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add one or more unittests for this?
Mostly to check that we do not regress if changes are made to this part of the codebase?
src/lightning/pytorch/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
…lt.py Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Signed-off-by: Wil Kong <[email protected]>
for more information, see https://pre-commit.ci
Good point, added a few unittests, thanks. |
Hi @SkafteNicki, what should I do to move forward? |
@alpha0422 PR looks fine to me. We are having progrems with our CI at the moment so it may take a bit of time before the PR is merged. |
What does this PR do?
Fixes #21232.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @csarofeen @ptrblck @eqy