Skip to content

Remove unnecessary TODO comment in fit_loop.py #21265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove unnecessary TODO comment in fit_loop.py #21265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12bec5
Initial plan
Copilot Oct 4, 2025
9499e9e
Remove unnecessary TODO comment in fit_loop.py
Copilot Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lightning/pytorch/loops/fit_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def done(self) -> bool:
rank_zero_info("`Trainer.fit` stopped: No training batches.")
return True

# TODO: Move track steps inside training loop and move part of these condition inside training loop
stop_steps = _is_max_limit_reached(self.epoch_loop.global_step, self.max_steps)
if stop_steps:
rank_zero_info(f"`Trainer.fit` stopped: `max_steps={self.max_steps!r}` reached.")
Expand Down
Loading