Skip to content

[pre-commit.ci] pre-commit suggestions #21273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −7
Open

[pre-commit.ci] pre-commit suggestions #21273

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ace4a84
[pre-commit.ci] pre-commit suggestions
pre-commit-ci[bot] Oct 6, 2025
19fe9bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2025
ece78b5
Replace Prettier repo with custom version
Borda Oct 7, 2025
e3d986e
Merge branch 'master' into pre-commit-ci-update-config
deependujha Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ci:

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
rev: v6.0.0
hooks:
- id: end-of-file-fixer
- id: trailing-whitespace
Expand Down Expand Up @@ -70,7 +70,7 @@ repos:
- id: sphinx-lint

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.12.2
rev: v0.13.3
hooks:
# try to fix what is possible
- id: ruff
Expand All @@ -96,7 +96,7 @@ repos:
)$

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
rev: v4.0.0-alpha.8
hooks:
- id: prettier
# https://prettier.io/docs/en/options.html#print-width
Expand Down
3 changes: 2 additions & 1 deletion tests/tests_pytorch/graveyard/test_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@

def test_precision_plugin_renamed_imports():
# base class
from lightning.pytorch.plugins.precision.precision_plugin import PrecisionPlugin as PrecisionPlugin0

from lightning.pytorch.plugins import PrecisionPlugin as PrecisionPlugin2
from lightning.pytorch.plugins.precision import PrecisionPlugin as PrecisionPlugin1
from lightning.pytorch.plugins.precision.precision import Precision
from lightning.pytorch.plugins.precision.precision_plugin import PrecisionPlugin as PrecisionPlugin0

assert issubclass(PrecisionPlugin0, Precision)
assert issubclass(PrecisionPlugin1, Precision)
Expand Down
5 changes: 3 additions & 2 deletions tests/tests_pytorch/utilities/test_model_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@ def test_is_overridden():
reason="This test is ONLY relevant for the UNIFIED package",
)
def test_mixed_imports_unified():
from lightning.pytorch.utilities.compile import _maybe_unwrap_optimized as new_unwrap
from lightning.pytorch.utilities.model_helpers import is_overridden as new_is_overridden
from pytorch_lightning.callbacks import EarlyStopping as OldEarlyStopping
from pytorch_lightning.demos.boring_classes import BoringModel as OldBoringModel

from lightning.pytorch.utilities.compile import _maybe_unwrap_optimized as new_unwrap
from lightning.pytorch.utilities.model_helpers import is_overridden as new_is_overridden

model = OldBoringModel()
with pytest.raises(TypeError, match=r"`pytorch_lightning` object \(BoringModel\) to a `lightning.pytorch`"):
new_unwrap(model)
Expand Down
Loading