Skip to content

nitpick: remove unnecessary type ignore & comment #21274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2025
Merged

nitpick: remove unnecessary type ignore & comment #21274

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bafcd04
refactor: remove unnecessary type ignore for partial function in _Syn…
deependujha Oct 7, 2025
75afd2e
Merge branch 'master' into nitpick-mypy
bhimrazy Oct 14, 2025
b43ac39
Merge branch 'master' into nitpick-mypy
bhimrazy Oct 15, 2025
3342950
Merge branch 'master' into nitpick-mypy
deependujha Oct 15, 2025
485969e
Merge branch 'master' into nitpick-mypy
deependujha Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/lightning/pytorch/trainer/connectors/logger_connector/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ def _generate_sync_fn(self) -> None:
"""Used to compute the syncing function and cache it."""
fn = self.no_op if self.fn is None or not self.should or self.rank_zero_only else self.fn
# save the function as `_fn` as the meta are being re-created and the object references need to match.
# ignore typing, bad support for `partial`: mypy/issues/1484
self._fn: Callable = partial(fn, reduce_op=self.op, group=self.group) # type: ignore[unused-ignore]
self._fn: Callable = partial(fn, reduce_op=self.op, group=self.group)

@property
def __call__(self) -> Any:
Expand Down
Loading