Fix edgecase for early stopping #21279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
Comment on lines
+180
to
+189
| stop_steps = _is_max_limit_reached(self.epoch_loop.global_step, self.max_steps) | ||
| if stop_steps: | ||
| rank_zero_info(f"`Trainer.fit` stopped: `max_steps={self.max_steps!r}` reached.") | ||
| return True | ||
|
|
||
| # Check early stopping before max_epochs to prioritize user-initiated stopping | ||
| if self.trainer.should_stop and self._can_stop_early: | ||
| rank_zero_debug("`Trainer.fit` stopped: `trainer.should_stop` was set.") | ||
| return True | ||
|
|
There was a problem hiding this comment.
I'd suggest moving the early_stopping check before the stop_steps check, since I think the checks for stop_steps and stop_epochs should occur at the same stage in the overall done determination process - wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21031
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21279.org.readthedocs.build/en/21279/