-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix ModelParallelStrategy fails with non-distributed checkpoint. #21384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
littlebullGit
wants to merge
3
commits into
Lightning-AI:master
Choose a base branch
from
littlebullGit:fix/21357-modelparallel-checkpoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix ModelParallelStrategy fails with non-distributed checkpoint. #21384
littlebullGit
wants to merge
3
commits into
Lightning-AI:master
from
littlebullGit:fix/21357-modelparallel-checkpoint
+196
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82f9a7d to
db3d718
Compare
db3d718 to
d4e476f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21384 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 269 266 -3
Lines 23804 23775 -29
=========================================
- Hits 20626 18752 -1874
- Misses 3178 5023 +1845 |
31b0976 to
646e01b
Compare
90af5cb to
cd663c6
Compare
SkafteNicki
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distributed
Generic distributed-related topic
pl
Generic label for PyTorch Lightning package
torch.compile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
KeyError('model.0.weight')reproduces in CI.torch.compilewraps the module, optimizer states get rekeyed through both the compiled wrapper and the original module before single-file checkpointing, preventing the KeyError.Fixes #21357
Before submitting