Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Nov 27, 2025

What does this PR do?

Temporarily reverts rerouting.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added docs Documentation related ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, requirements/pytorch/base.txt, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/test_tpu.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_comet.py, tests/tests_pytorch/loggers/test_mlflow.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_tpu.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_xla.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/migration/test_utils.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success

These checks are required after the changes to requirements/pytorch/base.txt, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/test_tpu.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_comet.py, tests/tests_pytorch/loggers/test_mlflow.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_tpu.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_xla.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/migration/test_utils.py, requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, .github/workflows/docs-build.yml, requirements/fabric/base.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, docs/source-pytorch/conf.py, .github/workflows/docs-build.yml, requirements/pytorch/base.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/graveyard/test_tpu.py, tests/tests_fabric/plugins/environments/test_kubeflow.py, tests/tests_fabric/plugins/environments/test_slurm.py, tests/tests_fabric/plugins/environments/test_torchelastic.py, tests/tests_fabric/plugins/environments/test_xla.py, tests/tests_fabric/plugins/precision/test_transformer_engine.py, tests/tests_fabric/strategies/test_deepspeed.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, fabric, 3.10) success
fabric.yml / Lit Job (fabric, 3.12) success
fabric.yml / Lit Job (lightning, 3.12) success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/graveyard/test_tpu.py, tests/tests_fabric/plugins/environments/test_kubeflow.py, tests/tests_fabric/plugins/environments/test_slurm.py, tests/tests_fabric/plugins/environments/test_torchelastic.py, tests/tests_fabric/plugins/environments/test_xla.py, tests/tests_fabric/plugins/precision/test_transformer_engine.py, tests/tests_fabric/strategies/test_deepspeed.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, requirements/fabric/base.txt, requirements/pytorch/base.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 56.45806% with 981 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (b09e96e) to head (12d684c).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21385     +/-   ##
=========================================
- Coverage      89%      87%     -3%     
=========================================
  Files         269      269             
  Lines       22063    23804   +1741     
=========================================
+ Hits        19737    20626    +889     
- Misses       2326     3178    +852     

@lantiga lantiga merged commit 25c9922 into master Nov 27, 2025
120 checks passed
@lantiga lantiga deleted the revert_integration branch November 27, 2025 11:32
@deependujha deependujha mentioned this pull request Nov 28, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants