Skip to content

Conversation

Isalia20
Copy link
Contributor

@Isalia20 Isalia20 commented Apr 6, 2025

What does this PR do?

Fixes #3031
This PR should be merged for the release after the next release. First this one should be released:
#3041 and for the next release this PR should be merged

  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?

📚 Documentation preview 📚: https://torchmetrics--3042.org.readthedocs.build/en/3042/

@Isalia20 Isalia20 mentioned this pull request Apr 6, 2025
2 tasks
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35%. Comparing base (4fb185f) to head (f68242b).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4fb185f) and HEAD (f68242b). Click for more details.

HEAD has 132 uploads less than BASE
Flag BASE (4fb185f) HEAD (f68242b)
torch2.0.1+cpu 9 3
python3.10 33 11
Windows 6 2
cpu 48 16
macOS 9 3
torch2.0.1 6 2
torch2.7.1 3 1
python3.12 12 4
torch2.7.1+cpu 9 3
Linux 33 11
torch2.6.0+cpu 6 2
torch2.3.1+cpu 3 1
python3.9 3 1
torch2.1.2+cpu 3 1
torch2.4.1+cpu 3 1
torch2.5.1+cpu 3 1
torch2.2.2+cpu 3 1
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3042     +/-   ##
========================================
- Coverage      70%     35%    -36%     
========================================
  Files         364     349     -15     
  Lines       20100   19905    -195     
========================================
- Hits        14123    6894   -7229     
- Misses       5977   13011   +7034     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to block this to make sure it is not merged by accident too early

@SkafteNicki SkafteNicki marked this pull request as draft April 7, 2025 05:48
@SkafteNicki SkafteNicki added this to the v1.9.0 milestone Apr 7, 2025
@Borda
Copy link
Collaborator

Borda commented Apr 8, 2025

@SkafteNicki so when this shall be merged?

@SkafteNicki
Copy link
Collaborator

@SkafteNicki so when this shall be merged?

Marked it for v1.9 release

@Borda Borda changed the title Dice score average = macro default Dice score average = macro default [hold for v1.9] Apr 29, 2025
@Borda Borda changed the title Dice score average = macro default [hold for v1.9] Dice score average = macro default Jul 23, 2025
@Borda Borda marked this pull request as ready for review July 23, 2025 17:51
@mergify mergify bot removed the has conflicts label Jul 25, 2025
@mergify mergify bot requested a review from a team July 25, 2025 12:30
@mergify mergify bot added the ready label Jul 25, 2025
@Borda Borda merged commit 27e1dbe into Lightning-AI:master Jul 25, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiceScore uses average='micro' by default, while other methods use average='macro'

3 participants