Skip to content

Conversation

VijayVignesh1
Copy link

@VijayVignesh1 VijayVignesh1 commented Oct 7, 2025

What does this PR do?

Fixes #3084

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review
Added a new domain called timeseries to include Soft DTW loss.
Ref paper: https://arxiv.org/abs/1703.01541

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3287.org.readthedocs.build/en/3287/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 7, 2025
@VijayVignesh1
Copy link
Author

@Borda Just wanted to get your initial opinion on this before I move forward. The softDTW uses dynamic programming which makes it really slow to work with on cpus. It's runs faster on gpus. Do you think it's worth continuing the effort?

@Borda
Copy link
Contributor

Borda commented Oct 8, 2025

@Borda Just wanted to get your initial opinion on this before I move forward. The softDTW uses dynamic programming which makes it really slow to work with on cpus. It's runs faster on gpus. Do you think it's worth continuing the effort?

I think it is very fine to have only the GPU version and raise an exception or a warning on the CPU

@VijayVignesh1 VijayVignesh1 changed the title New metric: Soft Dtw Loss [WIP] New Metric: Soft Dtw Loss [WIP] Oct 9, 2025
@VijayVignesh1 VijayVignesh1 changed the title New Metric: Soft Dtw Loss [WIP] New Metric: Soft Dynamic Time Warping (Soft-DTW) Oct 9, 2025
@VijayVignesh1 VijayVignesh1 marked this pull request as ready for review October 9, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request metrics for time series forecasting.

2 participants