Add metric_state property to CompositionalMetric for advance logging in lightning
#3309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Lightning-AI/pytorch-lightning#20153
PR does the following:
metric_stateproperty toCompositionalMetricMetricCollection, we can now make sure thatCompositonalMetriccreated from indexing the same underlying metric will end up in the same compute group and therefore only be calculated once even though they are now "separate" metricsThis has the intended purpose of getting users to just log the metric object instead of calling
computeandforwardthen logging the values themself, which can lead to problems (see linked issue).Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3309.org.readthedocs.build/en/3309/