Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 3, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

Addressing discovery in python-jsonschema/check-jsonschema#552

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--384.org.readthedocs.build/en/384/

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Apr 3, 2025
@Borda Borda requested a review from Copilot April 3, 2025 15:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with parsing the Azure schema in the CI pipeline as identified in a related check-jsonschema pull request. Key changes include:

  • Updating the check-schema workflow to pass the "--regex-variant" option set to "nonunicode".
  • Adjusting the changelog to reflect recent CI fixes and script usage updates.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
CHANGELOG.md Reorganized changelog entries to incorporate recent fixes and the script coverage usage update.
.github/workflows/check-schema.yml Modified the check-jsonschema command to include the "--regex-variant="nonunicode"" flag.
Files not reviewed (1)
  • scripts/run_standalone_tests.sh: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/check-schema.yml:93

  • Ensure that the '--regex-variant="nonunicode"' option is supported by the current version of check-jsonschema and does not inadvertently affect validations for files that might require Unicode support.
check-jsonschema -v $f --schemafile "$SCHEMA_FILE" --regex-variant="nonunicode";

@Borda Borda merged commit f38ec81 into main Apr 3, 2025
57 checks passed
@Borda Borda deleted the fix/schema branch April 3, 2025 15:45
Borda added a commit that referenced this pull request Apr 3, 2025
(cherry picked from commit f38ec81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration and delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant