Skip to content

Conversation

@thgml05
Copy link

@thgml05 thgml05 commented May 15, 2022

capture1
capture2
capture3

Copy link

@devHudi devHudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 컴포넌트 설계와 네이밍이 깔끔하고 읽기 좋았던 것 같아요 💯
몇가지 수정하면 좋을 만한 점을 코멘트 달아드렸어요. 반영해주셔도 좋고, 참고만 해주셔도 좋습니다 😁

src/App.js Outdated
Comment on lines 10 to 13
<GlobalStyle></GlobalStyle>
<Bar></Bar>
<Main></Main>
<ItemBox></ItemBox>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<GlobalStyle></GlobalStyle>
<Bar></Bar>
<Main></Main>
<ItemBox></ItemBox>
<GlobalStyle/>
<Bar/>
<Main/>
<ItemBox/>

self-closing tag 를 사용해볼 수 있겠군요 🙂

Comment on lines 49 to 61
const Item = (props) => {
return (
<Thumbnails>
<Thumbnail>
<Image url={props.url}></Image>
<Text>
<Content>{props.content}</Content>
<Minute>{props.min}</Minute>
</Text>
</Thumbnail>
</Thumbnails>
);
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트 구성이 깔끔하네요 👍

Comment on lines +24 to +29
<Container>
<Item
url="jeju.jpg"
content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer."
min="9 mins"
></Item>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Container>
<Item
url="jeju.jpg"
content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer."
min="9 mins"
></Item>
<Container>
<Item
url="jeju.jpg"
content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer."
min="9 mins"
/>

여기도 self-closing tag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants