Open
Conversation
thgml05
commented
May 15, 2022
thgml05
commented
devHudi
requested changes
May 15, 2022
devHudi
left a comment
devHudi
left a comment
There was a problem hiding this comment.
전체적으로 컴포넌트 설계와 네이밍이 깔끔하고 읽기 좋았던 것 같아요 💯
몇가지 수정하면 좋을 만한 점을 코멘트 달아드렸어요. 반영해주셔도 좋고, 참고만 해주셔도 좋습니다 😁
src/App.js
Outdated
Comment on lines
10
to
13
| <GlobalStyle></GlobalStyle> | ||
| <Bar></Bar> | ||
| <Main></Main> | ||
| <ItemBox></ItemBox> |
There was a problem hiding this comment.
Suggested change
| <GlobalStyle></GlobalStyle> | |
| <Bar></Bar> | |
| <Main></Main> | |
| <ItemBox></ItemBox> | |
| <GlobalStyle/> | |
| <Bar/> | |
| <Main/> | |
| <ItemBox/> |
self-closing tag 를 사용해볼 수 있겠군요 🙂
Comment on lines
49
to
61
| const Item = (props) => { | ||
| return ( | ||
| <Thumbnails> | ||
| <Thumbnail> | ||
| <Image url={props.url}></Image> | ||
| <Text> | ||
| <Content>{props.content}</Content> | ||
| <Minute>{props.min}</Minute> | ||
| </Text> | ||
| </Thumbnail> | ||
| </Thumbnails> | ||
| ); | ||
| }; |
Comment on lines
+24
to
+29
| <Container> | ||
| <Item | ||
| url="jeju.jpg" | ||
| content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer." | ||
| min="9 mins" | ||
| ></Item> |
There was a problem hiding this comment.
Suggested change
| <Container> | |
| <Item | |
| url="jeju.jpg" | |
| content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer." | |
| min="9 mins" | |
| ></Item> | |
| <Container> | |
| <Item | |
| url="jeju.jpg" | |
| content="This is a wider card with supporting text below as a natural lead-in to additional content. This content is a little bit longer." | |
| min="9 mins" | |
| /> |
여기도 self-closing tag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.