Skip to content

Conversation

@LilithHafner
Copy link
Owner

I used warmup with true,false, and nothing as options rather than force_warmup with true and false as options because

  • It is more concise
  • It is actually sometimes reasonable to force no-warmup, specifically if the computation is slow and pre-warmed.

@LilithHafner
Copy link
Owner Author

Regressiontests.jl found an unacceptable Chairmarks performance regression

Increase
ttfx_excl_load_time
@ /home/runner/work/Chairmarks.jl/Chairmarks.jl/bench/runbenchmarks.jl:12
primary                                                ▇                 
▁ ▁ ▁ ▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▂▂▁▁▁▁▁▁▁▂▂▂▂▂▄█▅▂▂▂▁▁▁▁▁▁ ▁ ▁ ▁ 
comparison      ▄                                                        
▁ ▁ ▂ ▂▁▂▁▁▂▂▂▂▄█▇▂▂▁▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ▁ ▁ ▁ 
∞ 0 < └0.133766                                           2.64779┘ < ∞ N

@LilithHafner
Copy link
Owner Author

Regressions are acceptable. There is already dynamic dispatch here and the regressions are small.

@LilithHafner LilithHafner changed the title Add option to force warmup (or no warmup Add option to force warmup (or no warmup) Jul 26, 2025
@LilithHafner LilithHafner merged commit 5267820 into main Jul 26, 2025
18 of 21 checks passed
@LilithHafner LilithHafner deleted the lh/warmup branch July 26, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants