Align with spec: fix semantic issues and missing assertions#9
Merged
Aurele-Barriere merged 7 commits intomainfrom Mar 16, 2026
Merged
Align with spec: fix semantic issues and missing assertions#9Aurele-Barriere merged 7 commits intomainfrom
Aurele-Barriere merged 7 commits intomainfrom
Conversation
This fix doesn't change the functionnality as the first parameter of countLeftCapturingParensBefore is not used, but it captures better the specs
Since we test for failure later, the use of let! is not necessary here
Aurele-Barriere
approved these changes
Mar 16, 2026
Collaborator
Aurele-Barriere
left a comment
Aurele-Barriere
left a comment
There was a problem hiding this comment.
Thank you for these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes inconsistencies between the code and the ECMAScript comments.
It also updates the associated proofs to account for the corrected semantics.
Changes
Terminstead ofAtomincountLeftCapturingParensBeforeto match the specification.assertin the group compilation logic and adapt the proof accordingly.OMITTEDspec step.let!withletwhere no monadic bind is required.Goals