This repository was archived by the owner on Feb 17, 2021. It is now read-only.
Horizontal window scrolling if needed.#358
Open
avadhpatel wants to merge 5 commits intoLinkedInAttic:masterfrom
Open
Horizontal window scrolling if needed.#358avadhpatel wants to merge 5 commits intoLinkedInAttic:masterfrom
avadhpatel wants to merge 5 commits intoLinkedInAttic:masterfrom
Conversation
The code was not taking X position of window and bubble into account to scroll in horizontal direction. This was causing issues with tour where the element is not in the view and horizontal scrolling was needed. Signed-off-by: Avadh Patel <avadh4all@gmail.com>
This patch is from Payton Quackenbush. Signed-off-by: Avadh Patel <avadh4all@gmail.com>
If its set, it renders the bubble in the center of the window regardless of the target position. This option can be used to create a bubble with information about the page and not a specific target element in the page. Signed-off-by: Avadh Patel <avadh4all@gmail.com>
Also added new API function 'clearState' to cleanup cookies stored by hopscotch. Signed-off-by: Avadh Patel <avadh4all@gmail.com>
Signed-off-by: Avadh Patel <avadh4all@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The 'adjustWindowScroll' only scrolls in the vertical direction!
The code was not taking X position of window and bubble into account to
scroll in the horizontal direction. This was causing issues with the tour where
the element is not in the view and horizontal scrolling was needed.
Solution
This patch modify's 'adjustWindowScroll' function to check if scrolling in
the X direction is also needed or not and performs the scrolling animation
accordingly.
Signed-off-by: Avadh Patel avadh4all@gmail.com