This repository was archived by the owner on Feb 17, 2021. It is now read-only.
Fixed test execution and added yarn.lock so it stays that way#360
Open
Benjamin-Dobell wants to merge 1 commit intoLinkedInAttic:masterfrom
Open
Fixed test execution and added yarn.lock so it stays that way#360Benjamin-Dobell wants to merge 1 commit intoLinkedInAttic:masterfrom
Benjamin-Dobell wants to merge 1 commit intoLinkedInAttic:masterfrom
Conversation
Contributor
Author
|
I should probably note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the build and test execution.
It was actually surprisingly complicated to come up with a set of dependency versions that work. For example, newer versions of rollup seem to contain a bug that was incorrectly tree-shaking away code that causes tests (and the corresponding real functionality) to fail.
As such I've added a lock file so that no-one else has to go through the painful dependency versioning trial and error I just went through!