-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use double quotes consistently in hostmot2(9) #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Le dim. 17 juil. 2022 à 08:16, petterreinholdtsen ***@***.***>
a écrit :
Converted bogus contraction to genitive and expand contractions to
make text easier to read.
Not sure to my english that meaning is preserved with some of your fixes 🤔
The "'s" usually denotes a link of belonging wich is somehow lost by simply
replacing it by a plural form.
I'd make good use of the help of a native english literate on this one...
|
945b1fd to
c8c19de
Compare
Collaborator
Author
|
[Jérémie Tarot]
The "'s" usually denotes a link of belonging wich is somehow lost by
simply replacing it by a plural form.
You are right, and I am wrong. I dropped that part of the patch.
…--
Happy hacking
Petter Reinholdtsen
|
Collaborator
|
What is the significance of switching from single-quotes ( |
Contributor
|
Le lun. 18 juil. 2022 à 16:39, Sebastian Kuzminsky ***@***.***>
a écrit :
What is the significance of switching from single-quotes (') to
double-quotes (") here? In other words, why is that part of this patch
useful?
Real question is which one _should_ be used!?
In French, we only use double quotes, what about english?
|
Collaborator
Author
|
And once we know which quotes to use, it could get included in the style guide in #1530. |
Contributor
|
Le mer. 20 juil. 2022 à 10:33, petterreinholdtsen ***@***.***>
a écrit :
https://proofreadanywhere.com/single-quotes-vs-double-quotes/ looks good to
me
|
Collaborator
Author
|
[Jérémie Tarot]
https://proofreadanywhere.com/single-quotes-vs-double-quotes/ looks
good to me
Good call to track down a USA style guide. If American English is the
wanted choice, it seem like a good done:
If British English is the choice, the Cambridgef style available
from <URL: https://www.cam.ac.uk/brand-resources/editorial-style-guide >
might be a better choice:
Quotation marks As we write in British English, we use single
quotation marks for thoughts or reported quotations that are sourced
from text. We use double quotation marks for speech (direct
quotes). For example, a headline might say Gold's 'intrinsic' value
questioned but within the text, if the article's author has
interviewed someone and is reporting their words verbatim, you would
see "I would not say that gold has an intrinsic value". Bear in mind
that when using single quotation marks, quotes within quotes use
double quote marks; this pattern is reversed for quotes within
reported speech marks.
A full stop is used outside the quotation mark if the quote is only
part of a sentence. (The scientists believed that there was a real
need 'to get out of the office and into the field'.) It is placed
inside the quotation mark if the quote is a complete sentence.
When you break a quote into two paragraphs, you omit the closing
speech marks at the end of the first paragraph and start the second
paragraph with opening speech marks. Here is an example:
“…the rainforest was threatened by logging companies.
“However, the government is now taking action to halt illegal
activities in this precious habitat...”
Single quotes also signify unfamiliar words or phrases. They should
not be used for words which are well understood, eg real life and GM.
Do not use end punctuation to close a pull-out quote.
Given that the project originated in USA, I suspect the Chicago Manual
of Style is a better choice, but I can not find it available on the
Internet. The Cambridgef style on the other hand is published on the
web.
As the quoting choice in this patch is controversial, I will move the
rest of the changes into a different pull request to have them processed
separately.
…--
Happy hacking
Petter Reinholdtsen
|
c8c19de to
3ef434f
Compare
Use double quotes consistently instead of a mix of single and double quotes. Picked double over single quotes as it had most existing use.
3ef434f to
2cb8f8f
Compare
Collaborator
Author
|
It seem like no-one is objecting any more to my proposal, and no-one is
around to make a decition on which quote style should be used. Based on
this, I recommend my patch to switch to " consistently is accepted and a
separate patch is made to add the Chicago style to the documentation
style guide.
…--
Happy hacking
Petter Reinholdtsen
|
Contributor
|
Le lun. 25 juil. 2022 à 12:20, petterreinholdtsen ***@***.***>
a écrit :
It seem like no-one is objecting any more to my proposal, and no-one is
around to make a decition on which quote style should be used. Based on
this, I recommend my patch to switch to " consistently is accepted and a
separate patch is made to add the Chicago style to the documentation
style guide
Perfect for me 👌
|
Collaborator
Author
|
[Sebastian Kuzminsky]
What is the significance of switching from single-quotes (`'`) to
double-quotes (`"`) here? In other words, why is that part of this
patch useful?
Consistency, and allowing the reader to not wonder what significance the
selected quote character has. I just picked one of them fairly at
random, could have picked the other one too.
…--
Happy hacking
Petter Reinholdtsen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use double quotes consistently instead of a mix of single and double quotes. Picked double over single quotes as it had most existing use.