-
Notifications
You must be signed in to change notification settings - Fork 61
feat: support to rename test suite and case #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are 1 test cases, failed count 0:
Reported by api-testing. |
8d5fad6 to
c5be726
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
yuluo-yx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
The e2e was failed. I didn't figure out the reason yet. |
may be the problem here? |
|
Yes, I don't konw why the etcd extension is not ready. |
62e36f4 to
e3e6088
Compare
e3e6088 to
e74af38
Compare
|
hi @yuluo-yx I fixed it. Actually, the e2e helped me find the potential issues. The tests failed due to incorrect lock usage. The wrong usage: s.lock.Lock()
defer s.lock.Unlock()
s.filesNeedToBeRemoved = append(s.filesNeedToBeRemoved, socketFile)
s.extStatusMap[pluginName] = truethe correct one: s.lock.Lock()
s.filesNeedToBeRemoved = append(s.filesNeedToBeRemoved, socketFile)
s.extStatusMap[pluginName] = true
s.lock.Unlock() |



What type of PR is this?
What this PR does / why we need it:


Which issue(s) this PR fixes:
Fixes #