Skip to content

Conversation

@user-xixiboliya
Copy link
Contributor

Fix: Testing panel switching bug.See Issue #759

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

What type of PR is this?

fix: Testing panel switching bug fix

Which issue(s) this PR fixes:

fix: A little bug of Testing panel switching #759

@sonarqubecloud
Copy link

Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your effort.

如果希望对测试用例集执行性能测试的话,可以增加响应的参数:
`atest run -p sample/testsuite-gitlab.yaml --duration 1m --thread 3 --report m`
`atest run -p sample/testsuite-gitlab.yaml --duration 1m --thread 3 --report md`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the small fix.

Comment on lines +67 to +73
<style>
.config {
margin: 6px 0;
display: flex;
align-items: center;
gap: 8px;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improvement is great. But I'm thinking if it's possible to create a global class for all similar positions and layouts. So it would be easy to have a consistent UI. You can even try to add it to the theme css.

https://github.com/LinuxSuRen/api-testing/blob/master/console/atest-ui/src/assets/base.css

Copy link
Contributor Author

@user-xixiboliya user-xixiboliya Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great.I will modified it in next PR and make larger changes,not just little fix. And more for that ,I will try to contribute to small database-related optimizations.

Also,should I delete TsetingPannel branch in my forked repository after "next PR"?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to delete that branch. But please always check out a new branch from master. I highly recommend you use https://github.com/cli/cli

A few very simple steps:

  • gh repo clone
  • gh repo fork
  • git add . && git commit -m 'xxx'
  • gh pr create

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@LinuxSuRen LinuxSuRen added bug Something isn't working chore skip-changelog labels Jul 11, 2025
@LinuxSuRen LinuxSuRen linked an issue Jul 11, 2025 that may be closed by this pull request
@LinuxSuRen LinuxSuRen merged commit c3d8678 into LinuxSuRen:master Jul 11, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A little bug of Testing panel switching

2 participants