-
Notifications
You must be signed in to change notification settings - Fork 61
Testing panel switching bug fix #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing panel switching bug fix #760
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your effort.
| 如果希望对测试用例集执行性能测试的话,可以增加响应的参数: | ||
| `atest run -p sample/testsuite-gitlab.yaml --duration 1m --thread 3 --report m` | ||
| `atest run -p sample/testsuite-gitlab.yaml --duration 1m --thread 3 --report md` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see the small fix.
| <style> | ||
| .config { | ||
| margin: 6px 0; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improvement is great. But I'm thinking if it's possible to create a global class for all similar positions and layouts. So it would be easy to have a consistent UI. You can even try to add it to the theme css.
https://github.com/LinuxSuRen/api-testing/blob/master/console/atest-ui/src/assets/base.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great.I will modified it in next PR and make larger changes,not just little fix. And more for that ,I will try to contribute to small database-related optimizations.
Also,should I delete TsetingPannel branch in my forked repository after "next PR"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary to delete that branch. But please always check out a new branch from master. I highly recommend you use https://github.com/cli/cli
A few very simple steps:
- gh repo clone
- gh repo fork
- git add . && git commit -m 'xxx'
- gh pr create
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.



Fix: Testing panel switching bug.See Issue #759
What type of PR is this?
fix: Testing panel switching bug fix
Which issue(s) this PR fixes:
fix: A little bug of Testing panel switching #759