Skip to content

fix: desktop build error #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

fix: desktop build error #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b2daa9
fix: desktop build error
LinuxSuRen Oct 27, 2025
89df62e
remove install dir setting part
LinuxSuRen Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions console/atest-desktop/forge.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,33 +52,6 @@ module.exports = {
"enabled": true,
"chooseDirectory": true
},
beforeCreate: (msiCreator) => {
// Add installation directory to system PATH
msiCreator.wixTemplate = msiCreator.wixTemplate.replace(
'</Product>',
` <Property Id="ARPINSTALLLOCATION" Value="[INSTALLDIR]" />
<CustomAction Id="AddToPath" Property="PATH" Value="[INSTALLDIR]" Execute="immediate" />
<CustomAction Id="RemoveFromPath" Property="PATH" Value="[INSTALLDIR]" Execute="immediate" />

<InstallExecuteSequence>
<Custom Action="AddToPath" After="InstallFiles">NOT Installed</Custom>
<Custom Action="RemoveFromPath" Before="RemoveFiles">REMOVE="ALL"</Custom>
</InstallExecuteSequence>

<Component Id="PathComponent" Guid="*" Directory="INSTALLDIR">
<Environment Id="PATH" Name="PATH" Value="[INSTALLDIR]" Permanent="no" Part="last" Action="set" System="yes" />
</Component>

</Product>`
);

// Ensure INSTALLDIR is properly defined in the existing ProgramFilesFolder
msiCreator.wixTemplate = msiCreator.wixTemplate.replace(
'<Directory Id="ProgramFilesFolder">',
`<Directory Id="ProgramFilesFolder">
<Directory Id="INSTALLDIR" Name="API Testing" />`
);
}
}
}
],
Expand Down
57 changes: 18 additions & 39 deletions console/atest-desktop/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion console/atest-desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"publish": "electron-forge publish"
},
"engines": {
"node": "22.12.0"
"node": ">=22.12.0"
},
"author": "linuxsuren",
"license": "ISC",
Expand Down
Loading