Skip to content

Feature: Home button added to the subpage nav bar #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+21 −11
Open

Feature: Home button added to the subpage nav bar #1918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ec9ac0
feat(nav): add Home button on sub-pages and hide current page from nav
aspenyang Sep 14, 2025
012e50f
Merge branch 'master' into page-list
aspenyang Sep 17, 2025
73f5a85
fix(nav): move v-for key to rendered elements and fix indentation
aspenyang Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions src/components/PageStrcture/Nav.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@
<nav id="nav" v-if="navVisible">
<!-- Render either router-link or anchor, depending if internal / external link -->
<template v-for="(link, index) in allLinks">
<router-link v-if="!isUrl(link.path)"
<router-link
v-if="!isUrl(link.path)"
:key="index"
:to="link.path"
class="nav-item"
>{{link.title}}
</router-link>
<a v-else
:class="['nav-item', link._isHome ? 'home-button' : '']"
>{{ link.title }}</router-link>
<a
v-else
:key="index"
:href="link.path"
:target="determineTarget(link)"
class="nav-item"
:class="['nav-item', link._isHome ? 'home-button' : '']"
rel="noopener noreferrer"
>{{link.title}}
</a>
>{{ link.title }}</a>
</template>
</nav>
</div>
Expand All @@ -44,15 +44,22 @@ export default {
isMobile: false,
}),
computed: {
/* Get links to sub-pages, and combine with nav-links */
/* Build nav links: custom links + sub-pages (excluding current) + optional Home button */
allLinks() {
const subPages = this.$store.getters.pages.filter((page) => checkPageVisibility(page))
const currentSubPageId = this.$store.state.currentConfigInfo?.confId || null;
let subPages = this.$store.getters.pages
.filter((page) => checkPageVisibility(page))
.map((subPage) => ({
path: makePageSlug(subPage.name, 'home'),
title: subPage.name,
_isSubPage: true,
}));
if (currentSubPageId) {
subPages = subPages.filter(p => !p.path.endsWith(`/${currentSubPageId}`));
}
const navLinks = this.links || [];
return [...navLinks, ...subPages];
const homeButton = currentSubPageId ? [{ path: '/home/', title: 'Home', _isHome: true }] : [];
return [...navLinks, ...subPages, ...homeButton];
},
},
created() {
Expand Down Expand Up @@ -107,6 +114,9 @@ export default {
border: 1px solid var(--nav-link-border-color-hover);
box-shadow: var(--nav-link-shadow-hover);
}
&.home-button {
font-weight: 600;
}
}
}
/* Mobile and Burger-Menu Styles */
Expand Down