fix WeatherForecast widget: time of day not being displayed #1974
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bugfix
Overview
For some time now, the weather forecast data fetched from OpenWeatherMap contains multiple forecasts per day (in my case, every three hours. Since the Vue template doesn't expect this, only the date is printed, which results in seemingly "multiple forecasts per day".
This PR fixes it by introducing a new "time" row, beneath the date. This way, it is clearly visible to the user which time instances are referred to by the forecasts.
Open issues:
numDaysdoesn't make sense. We could rename it tonumForecastInstancesor the likes.yarn testfails witherror Command "test" not found..yarn lint/devwork as expected. Any idea?)@, WDYT?
Issue Number fixes #1887
New Vars
Screenshot (if applicable)
Code Quality Checklist (Please complete)
//- [ ] (If a new config option is added) Attribute is outlined in the schema and documented
//- [ ] (If a new dependency is added) Package is essential, and has been checked out for security or performance
//- [ ] (If significant change) Bumps version in package.json