Skip to content

Conversation

@t-nil
Copy link

@t-nil t-nil commented Jan 4, 2026

t-nil Quick ✏️ Draft t-nil /issue-1887 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 7 Label Unchecked Tasks Powered by Pull Request Badge

Category: Bugfix

Overview
For some time now, the weather forecast data fetched from OpenWeatherMap contains multiple forecasts per day (in my case, every three hours. Since the Vue template doesn't expect this, only the date is printed, which results in seemingly "multiple forecasts per day".

This PR fixes it by introducing a new "time" row, beneath the date. This way, it is clearly visible to the user which time instances are referred to by the forecasts.

Open issues:

  • now the config var numDays doesn't make sense. We could rename it to numForecastInstances or the likes.
  • this is a relatively quick 'n' dirty fix, since I didn't want to look into the OWM API on how to force daily forecasts. But, atleast for me, I think 3 hour intervals are preferred anyways.
  • (yarn test fails with error Command "test" not found.. yarn lint/dev work as expected. Any idea?)

@, WDYT?

Issue Number fixes #1887

New Vars

nada

Screenshot (if applicable)

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
    //- [ ] (If a new config option is added) Attribute is outlined in the schema and documented
    //- [ ] (If a new dependency is added) Package is essential, and has been checked out for security or performance
    //- [ ] (If significant change) Bumps version in package.json

@netlify
Copy link

netlify bot commented Jan 4, 2026

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 8c8c19a
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/695a98a8d6594800085e3a0c
😎 Deploy Preview https://deploy-preview-1974--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Weather forecast showing same day multiple times

1 participant