Track players who have participated in a score, remove score type 7 #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… skip param for /friendscores, fix score game serialization
jvyden
requested changes
Oct 16, 2025
jvyden
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to sanitize and actually track the player data included in the
playerIdslist in the game's score submissions, while also tracking the user who actually published the score (since in online multiplayer, every player submits the score, not just the host). Also the server now uses that data to fix the "7-player mode" recent activity/score API bug by falling back to counting the usernames inplayerIdsand setting the type to that (guaranteed to be inbetween 1 and 4). Requesting a level leaderboard of type 7 just returns all scores for both the game and APIv3 regardless of their type now.Also adjusts and adds new score tests, improves overtake notifications to include the usernames of all participants of the new score aswell as the score type, and sends these notifications to all overtaken players who have not participated in the new score aswell. Also quickly made the LBP2+ friends leaderboard endpoint properly use the skip param since I was already at it.
Closes #201