feat: add Croatian (HR) national calendar and translations#485
feat: add Croatian (HR) national calendar and translations#485zcuric wants to merge 2 commits intoLiturgical-Calendar:developmentfrom
Conversation
Add complete Croatian liturgical calendar support including: National Calendar (HR.json): - St. Joseph as patron of Croatia (Mar 19, solemnity) - Bl. Alojzije Stepinac (Feb 10, memorial) - Bl. Ozana Kotorska (Apr 27, optional memorial) - Bl. Ivan Merz (May 10, optional memorial) - St. Leopold Mandić (May 12, memorial) - Bl. Marija od Propetog Isusa Petković (Jul 9, optional memorial) - Our Lady of Marija Bistrica (Jul 13, optional memorial) - Bl. Augustin Kažotić (Aug 3, optional memorial) - Bl. Miroslav Bulešić (Aug 24, optional memorial) - St. Mark of Križevci (Sep 7, memorial) - St. Jerome elevated to memorial (Sep 30) - Bl. Gracija Kotorski (Nov 8, optional memorial) - St. Nikola Tavelić (Nov 14, memorial) Settings configured for Croatian practice: - Epiphany on January 6 - Ascension on Thursday - Corpus Christi on Thursday i18n additions: - Croatian translations for ~40 liturgical terms in litcal.po - Croatian decree translations (hr.json) - Croatian lectionary files for all cycles - Croatian names for national calendar saints Also adds Croatian (hr) locale to OpenAPI schema.
WalkthroughAdds Croatian localization: updated translated strings, extended OpenAPI enums to accept "hr"/"HR", and introduced comprehensive Croatian calendar, decrees, and lectionary JSON data files (many placeholder readings and several prefilled entries). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
jsondata/schemas/openapi.json (1)
3431-3446: Update national calendar enums to include HR.You added
hrto the Easter locale enum, but the national calendar enums still list only IT/US/NL/VA/CA. With a new Croatian calendar, generated clients won’t acceptHRfor/calendar/nation/*and/events/nation/*. Please addHRto the inlinecalendar_idenums andcomponents/parameters/NationalCalendarIdPathParam.🛠️ Suggested patch (apply similarly to other inline enums)
"enum": [ "IT", "US", "NL", "VA", - "CA" + "CA", + "HR" ]i18n/hr/LC_MESSAGES/litcal.po (1)
1476-1481: Grammar: adjust adjective case for dative agreement.The adjective "vlastit" must agree in case with the dative noun "kalendaru". The nominative form "vlastit" should be changed to the dative form "vlastitom".
Suggested fix
-msgstr "%1$s '%2$s', vlastit kalendaru %3$s i obično slavljen %4$s, potisnut je od %5$s %6$s u godini %7$d." +msgstr "%1$s '%2$s', vlastitom kalendaru %3$s i obično slavljen %4$s, potisnut je od %5$s %6$s u godini %7$d."
🤖 Fix all issues with AI agents
In `@jsondata/sourcedata/decrees/lectionary/hr.json`:
- Around line 56-61: The StMotherTeresa entry uses Latin book names; update the
fields on the "StMotherTeresa" object to use Croatian/HR abbreviations: change
"Isaiæ" to "Iz" in first_reading, "Psalmo" to "Ps" in responsorial_psalm, and
"Matthæum" to "Mt" in gospel_acclamation and gospel; ensure punctuation/spacing
matches other HR lectionary entries (e.g., "Iz 58, 6-11", "Ps 33, 2-3. 4-5. 6-7.
8-9. 10-11", "Mt 11, 25", and "Mt 25, 31-46|Mt 25, 31-40").
In `@jsondata/sourcedata/lectionary/dominicale_et_festivum_A/hr.json`:
- Around line 383-402: The "EasterVigil" entry's gospel value is wrong for Year
A; update the "gospel" field inside the EasterVigil object (key "EasterVigil" ->
property "gospel") from "Lk 24,1-12" to the Year A value "Mt 28,1-10".
In `@jsondata/sourcedata/lectionary/dominicale_et_festivum_B/hr.json`:
- Around line 383-402: The EasterVigil entry has the wrong gospel for Year B;
update the "gospel" field inside the "EasterVigil" object from "Lk 24,1-12" to
the Year B reading "Mk 16,1-7" (modify the "gospel" value in the EasterVigil
JSON object).
In `@jsondata/sourcedata/lectionary/sanctorum/hr.json`:
- Around line 48-63: The "Assumption" entry currently duplicates the readings
from StsPeterPaulAp; replace the vigil and day objects under "Assumption" with
the official Croatian lectionary readings for the Assumption (update the values
for keys first_reading, responsorial_psalm, second_reading, gospel_acclamation,
gospel for both "vigil" and "day"), ensure the texts differ from StsPeterPaulAp,
and add a source note or comment in the surrounding metadata indicating the
official Croatian lectionary as the reference for these values.
- Around line 169-174: Rename the misspelled event keys to their canonical forms
so lookups match the en.json lectionary/missal: change "StFrancisDePsalmoes" to
"StFrancisDeSales", "StJohnBaptistDeLaPsalmole" to "StJohnBaptistDeLaSalle",
"StActushanasius" to "StAthanasius", and "StsMarcumellinusPeter" to
"StsMarcellinusPeter" in hr.json (and apply the identical renames in nl.json and
la.json); also verify the correct canonical key for "StIoannemVianney" against
en.json/propriumdesanctis_1970 and rename it to that exact canonical identifier
so all lookups succeed.
🧹 Nitpick comments (1)
i18n/hr/LC_MESSAGES/litcal.po (1)
202-204: Consider gender‑inclusive phrasing for “For Religious”.Line 204 uses “Za redovnike,” which can read as male‑only. If the intent is inclusive, consider a neutral or explicitly inclusive form. Please verify with a Croatian reviewer.
♻️ Suggested tweak (if inclusive wording is desired)
-msgstr "Za redovnike" +msgstr "Za redovnike i redovnice"
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@jsondata/sourcedata/lectionary/sanctorum/hr.json`:
- Around line 9-23: Update the "NativityJohnBaptist" -> "day" object so its
readings match the Roman Missal (Lectionary 587) instead of duplicating the
vigil: set "first_reading" to "Is 49,1-6", "responsorial_psalm" to "Ps 139",
"second_reading" to "Acts 13,22-26", "gospel_acclamation" to "Lk 1,76", and
"gospel" to "Lk 1,57-66,80" in the "day" entry (leave the "vigil" entry
unchanged).
|
@JohnRDOrazio Hey Fr. John! Can you look at this, and if it's ok merge it and publish it? God bless. :) |
|
Thank you for catching the inconsistencies in the keys in |
|
I believe there are some more missing translations that are required to complete this PR, see: |
|
@JohnRDOrazio Most of them, if not all, should be covered. Like, for example, "Proper" is added. If you check the diff, you can see that in .po file, all are translated. |
2 participants
Add complete Croatian liturgical calendar support including:
National Calendar (HR.json):
Settings configured for Croatian practice:
i18n additions:
Also adds Croatian (hr) locale to OpenAPI schema.
Summary by CodeRabbit
New Features
Data Corrections
✏️ Tip: You can customize this high-level summary in your review settings.