-
Notifications
You must be signed in to change notification settings - Fork 0
DATA-22937: LI analytics adapter #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # extra/bundle/pom.xml # extra/modules/live-intent-omni-channel-identity/pom.xml # extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/config/LiveIntentOmniChannelIdentityConfiguration.java # extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/model/IdResResponse.java # extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java # extra/modules/live-intent-omni-channel-identity/src/test/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest.java # extra/modules/pom.xml
This PR is being reviewed by Cursor BugbotDetailsYour team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team. To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Bug: Missing Validation Causes Null Pointer ExceptionsThe |
Bug: URIBuilder Overwrites Base Path IncorrectlyThe Additional Locations (1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| new URIBuilder(properties.getAnalyticsEndpoint()) | ||
| .setPath("/analytic-events/pbsj-bids") | ||
| .build() | ||
| .toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: URIBuilder Overwrites Path Instead of Appending
URIBuilder.setPath() replaces the entire path component of the URI instead of appending to it. If properties.getAnalyticsEndpoint() contains a path (e.g., "https://api.example.com/v1"), calling setPath("/analytic-events/pbsj-bids") will replace "/v1" with "/analytic-events/pbsj-bids", resulting in "https://api.example.com/analytic-events/pbsj-bids" instead of the likely intended "https://api.example.com/v1/analytic-events/pbsj-bids". The same issue exists in processNotificationEvent at lines 173-178. Consider using appendPath() or constructing the full path by concatenating with the existing path from the base endpoint.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check