Conversation
| Text::DetailedTimerTimerHeight => "タイマーの高さ", | ||
| Text::DetailedTimerTimerHeightDescription => "ランタイマーの高さ。", | ||
| Text::DetailedTimerSegmentTimerHeight => "セグメントタイマーの高さ", | ||
| Text::DetailedTimerSegmentTimerHeightDescription => "セグメントタイマーの高さ。", | ||
| Text::DetailedTimerTimerHeightDescription => "タイマーの高さ。", |
There was a problem hiding this comment.
The detailed timer has two timers. One is the timer for the full run and one is for the current segment. By using タイマー instead of ランタイマー you lose the nuance.
There was a problem hiding this comment.
Generally, when we say タイマー, it's understood to mean a timer that counts time from the start of an attempt. Since Text::DetailedTimerTimerHeight uses タイマー and Segment Timer is explicitly labeled as such, I concluded that タイマー would suffice here.
However, since this is a Description and the original nuance is certainly lost, it seems better to use タイマースタートからのタイマー.
src/localization/japanese.rs
Outdated
| Text::SumOfBestCleanerStartOfRun => "ラン開始", | ||
| Text::SumOfBestCleanerShouldRemove => { | ||
| " この区間タイムは不正確だと思いますか？ もしそうなら、削除したほうがいいでしょうか？" | ||
| " この区間タイムは不正確だと思いますか？ もしそうなら、削除したほうがいいでしょうか？" |
There was a problem hiding this comment.
There's a "small" space in front and now a "fat" space in the middle? Is that intended? That seems weird. (The small space in front was probably a mistake by me)
There was a problem hiding this comment.
As a rule primarily for Japanese text, a space is typically placed after a question mark. Therefore, I believe it is natural to include a space here.
However, this is not a rule that applies in all situations. In application UI, for example, spaces are often omitted. Considering that fat space should generally be avoided when small space are used, it might be better to omit the space here.
CryZe
force-pushed
the
replace-jp-term
branch
from
9c50424 to
133f3ea
Compare
`png` version `0.18.1` encodes the PNGs slightly differently than `0.18.0`.
CryZe
added
enhancement
2 participants
#897