Add swap_run_mid_attempt for mid-run route swapping#910
Open
shookietea wants to merge 2 commits intoLiveSplit:masterfrom
Open
Add swap_run_mid_attempt for mid-run route swapping#910shookietea wants to merge 2 commits intoLiveSplit:masterfrom
shookietea wants to merge 2 commits intoLiveSplit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assumes the frontend goes past simply using Game - Category distinction and instead has an option for routes. This could look like Majora's Mask - Glitchless Any% - 2 Bottle No Aliens. An alternative route in this case could be failing to complete the Goron Race, and must leave to get Epona and complete the Gormon Brothers' Race. In that example, Goron Race is moved later, as you must get Epona before a specific amount of IGT passes. Most of the time, segments can be set up so that it doesn't matter, but you know what they say. More is more
The main use case for this function is as follows:
This seemed to be the cleanest prerequisite to adding mid-run route swapping for a timer frontend I have in development. Making this change in livesplit-core allows for clean moving of segment information. Let me know if you'd like to chat about this or have a better solution using the available public methods