Skip to content

Add socket ID to unregisterClient and cleanup #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mroeder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add socket ID to unregisterClient and cleanup #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,17 @@ export default class L2LTracker extends L2LConnection {
}

removeDisconnectedClients() {
var ids = Array.from(this.clients.keys()),
toRemove = ids.filter(id => !this.getSocketForClientId(id));
toRemove.forEach(id => this.clients.delete(id));
if (toRemove.length)
console.log(`[l2l] ${this} removing disconnected clients ${ids.join(",")}`)
let ids = Array.from(this.clients.keys());
let toRemove = ids.filter(id => !this.getSocketForClientId(id));
toRemove = toRemove.map(id => {
let client = this.clients.get(id);
this.clients.delete(id);
return `${id} (${client ? client.socketId : ''})`;
});

if (toRemove.length) {
console.log(`[l2l] ${this} removing disconnected clients ${toRemove.join(',')}`);
}
}

open() {
Expand Down Expand Up @@ -163,8 +169,9 @@ export default class L2LTracker extends L2LConnection {
}

unregisterClient(_, answerFn, socket) {
var clientId = this.getClientIdForSocketId(socket.id);
this.debug && console.log(`[l2l] ${this} got unregister request ${clientId}`);
let clientId = this.getClientIdForSocketId(socket.id);
let client = this.clients.get(clientId);
console.log(`[l2l] ${this} got unregister request ${clientId} (${client ? client.socketId : ''})`);
this.clients.delete(clientId);
typeof answerFn === "function" && answerFn();
}
Expand Down