Fix/optimize morph derivation from component#1696
Merged
Conversation
Saves up to 40% in performance. The initial application is skipped in favor of just directly passing the style props to the morph constructor.
merryman
force-pushed
the
fix/optimize-morph-derivation-from-component
branch
from
04c2c40 to
ec17a0e
Compare
linusha
reviewed
Feb 5, 2025
linusha
approved these changes
Feb 5, 2025
This was referenced Feb 19, 2025
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue explained here #599 (comment), where when deriving new morphs from a component a completely unnecessary initial application step was performed.
We now avoid that by simply passing the stylized properties directly to the morph constructors. We also avoid overly permature policy application during morph addition that happens for morphs not yet mounted into the world.