Enhancement/chai upgrade #1711
Merged
Enhancement/chai upgrade #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
enhancement/chai-upgrade
branch
from
180c15a to
3fa270a
Compare
linusha
approved these changes
Jul 9, 2025
Contributor
linusha
left a comment
linusha
left a comment
There was a problem hiding this comment.
Once we are done with #1710, feel free to merge this in directly as well!
I ran all tests, headless and in the browser. Works like a charm, except some timing-critical ones, but these have been flaky since forever, that is nothing related to this PR.
Due to the upgrade in chai, we no longer have the chai subset convenience methods, so these need to be added by a custom 3rd party package.
This is nessecary due to the chai upgrade.
Due to upgrding chai, the comparison function that compares structs did not work any more since it started to compare prototypes as well. Wrapping the compared objects in JSON.parse/stringify seems to solve the issue.
merryman
force-pushed
the
enhancement/chai-upgrade
branch
from
3fa270a to
2544efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged as soon as #1710 has been merged.