🎨: handle text props directly within the spec#1722
Merged
Conversation
Contributor
|
|
Previously, we would perform the normalization of text props at the very latest stage of synthesization, thereby loosing the overriding precedence of style properties for text properties.
merryman
force-pushed
the
fix/text-prop-precedence
branch
from
ea3baf8 to
fa06dc0
Compare
Member
Author
|
Sorry, should be fixed now. |
linusha
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1721.
Previously, we would perform the normalization of text props at the very latest stage of synthesization, thereby loosing the overriding precedence of style properties for text properties.