Skip to content

use explicit resource management #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiviaMedeiros wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use explicit resource management #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 20 additions & 29 deletions lib/fs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,42 +20,33 @@ const rangeToFSOpts = (range, size = Infinity) => {
return { length: end - start + 1, position: start };
};

const readRanges = async (url, ranges, size, fd) => {
try {
fd ??= await open(url);
const readRanges = async (url, ranges, size) => {
await using fd = await open(url);

return Promise.all(ranges.map(range => {
const { length, position } = rangeToFSOpts(range, size);
return Promise.all(ranges.map(range => {
const { length, position } = rangeToFSOpts(range, size);

return fd.read(new Uint8Array(length), {
length,
position,
}).then(({ buffer }) => buffer);
}));
} finally {
await fd?.close();
}
return fd.read(new Uint8Array(length), {
length,
position,
}).then(({ buffer }) => buffer);
}));
};

const writeRange = async (url, range, body, flag) => {
let { length, position } = rangeToFSOpts(range);

let fd;
try {
fd = await open(url, flag);
for await (const $ of body) {
const byteLength = Math.min($.byteLength ?? $.length, length);
await fd.write(...ArrayBuffer.isView($)
? [new Uint8Array($.buffer, $.byteOffset, byteLength),,, position]
: [`${$}`.slice(0, byteLength), position]
);

if (!(length -= byteLength))
return;
position += byteLength;
}
} finally {
await fd?.close();
await using fd = await open(url, flag);
for await (const $ of body) {
const byteLength = Math.min($.byteLength ?? $.length, length);
await fd.write(...ArrayBuffer.isView($)
? [new Uint8Array($.buffer, $.byteOffset, byteLength),,, position]
: [`${$}`.slice(0, byteLength), position]
);

if (!(length -= byteLength))
return;
position += byteLength;
}
};

Expand Down
Loading